linux-kernel - Re: [PATCH -next v3] usb: musb: Do not check 0 for platform_get_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d45574ec-17cd-cd30-2c6f-8c2719f811e3@gmail.com>
Date:   Thu, 3 Aug 2023 19:44:07 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...il.com>
To:     Zhu Wang <wangzhu9@...wei.com>, b-liu@...com,
        gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next v3] usb: musb: Do not check 0 for
 platform_get_irq_byname()

On 8/3/23 3:00 PM, Zhu Wang wrote:

> When platform_get_irq_byname() failed, it may return -EPROBE_DEFER,

   s/failed/fails/, I think...

> -EINVAL or -ENXIO, it is important to propagate the detail upstream, we
> cannot override it.

   You better rename the patch to something like "usb: musb: Fix deferred
probing" now. And remove "-next:, as this became a real fix.

> And platform_get_irq_byname() used to return 0 (as both IRQ0 and error
> indication), there are several patches fixing the inconsistencies.

   In no way I suggested to take my "historical" passage into the
patch description!

> Commit ce753ad1549c ("platform: finally disallow IRQ0 in
> platform_get_irq() and its ilk") makes sure IRQ0 is not returned.
> 
> Signed-off-by: Zhu Wang <wangzhu9@...wei.com>
> 
> ---
> Changes in v2:
> - Update the commit message, present the reason of replacing the return
> value of the probe.
> 
> ---
> Changes in v3:
> - Update the commit message, explain in detail why the return value of
> platform_get_irq_byname() cannot be override.

   You didn't emphasize the deferred probing breakage we're trying to
fix here at last; the other error codes here are not very important...

[...]

MBR, Sergey