linux-kernel - Re: [PATCH -next v3] usb: gadget: udc: gr_udc: Do not check 0 for platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e85efc8e-5a12-5f9f-a23e-d701b5722896@gmail.com>
Date:   Thu, 3 Aug 2023 20:00:36 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...il.com>
To:     Zhu Wang <wangzhu9@...wei.com>, gregkh@...uxfoundation.org,
        herve.codina@...tlin.com, stern@...land.harvard.edu,
        robh@...nel.org, aaro.koskinen@....fi, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next v3] usb: gadget: udc: gr_udc: Do not check 0 for
 platform_get_irq()

On 8/3/23 3:11 PM, Zhu Wang wrote:

> When platform_get_irq() failed, it may return -EPROBE_DEFER, -EINVAL or
> -ENXIO, it is important to propagate the detail upstream, we cannot
> override it.

   Deferred probing being fixed should be emphasized. And the patch is
no longer "-next" material due to that...

> And platform_get_irq() used to return 0 (as both IRQ0 and error
> indication), there are several patches fixing the inconsistencies.

   No, this "historical" passage wasn't meant to be a part of the patch
description.

> Commit ce753ad1549c ("platform: finally disallow IRQ0 in
> platform_get_irq() and its ilk") makes sure IRQ0 is not returned.
> 
> Signed-off-by: Zhu Wang <wangzhu9@...wei.com>
> 
> ---
> Changes in v2:
> - Update the commit message, present the reason of replacing the return
> value of the probe.
> 
> ---
> Changes in v3:
> - Update the commit message, explain in detail why the return value of
> platform_get_irq() cannot be override.

   As I said, your descrioption isn't very convincing as you don't
emphasize the deferred probing being fixed.

[...]

MBR, Sergey