linux-kernel - Re: [PATCH] rcu-tasks: make rcu_tasks_lazy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 3 Aug 2023 11:40:27 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Joel Fernandes <joel@...lfernandes.org>
Cc:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        frederic@...nel.org, quic_neeraju@...cinc.com,
        josh@...htriplett.org, boqun.feng@...il.com, rostedt@...dmis.org,
        mathieu.desnoyers@...icios.com, jiangshanlai@...il.com,
        qiang.zhang1211@...il.com, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] rcu-tasks: make rcu_tasks_lazy_ms static

On Thu, Aug 03, 2023 at 12:11:41PM -0400, Joel Fernandes wrote:
> On Thu, Aug 3, 2023 at 4:07 AM Jiapeng Chong
> <jiapeng.chong@...ux.alibaba.com> wrote:
> >
> > The rcu_tasks_lazy_ms are not used outside the file tasks.h, so the
> > modification is defined as static.
> >
> > kernel/rcu/tasks.h:1085:5: warning: symbol 'rcu_tasks_lazy_ms' was not declared. Should it be static?
> >
> > Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6086
> > Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> 
> Reviewed-by: Joel Fernandes (Google) <joel@...lfernandes.org>

Queued, thank you both!

							Thanx, Paul

>  - Joel
> 
> 
> > ---
> >  kernel/rcu/tasks.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h
> > index 83049a893de5..ee1379671798 100644
> > --- a/kernel/rcu/tasks.h
> > +++ b/kernel/rcu/tasks.h
> > @@ -1084,7 +1084,7 @@ void rcu_barrier_tasks(void)
> >  }
> >  EXPORT_SYMBOL_GPL(rcu_barrier_tasks);
> >
> > -int rcu_tasks_lazy_ms = -1;
> > +static int rcu_tasks_lazy_ms = -1;
> >  module_param(rcu_tasks_lazy_ms, int, 0444);
> >
> >  static int __init rcu_spawn_tasks_kthread(void)
> > --
> > 2.20.1.7.g153144c
> >