linux-kernel - Re: [PATCH V4] Revert "PCI: tegra194: Enable support for 256 Byte payload"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 4 Aug 2023 03:50:31 +0900
From:   Krzysztof Wilczyński <kw@...ux.com>
To:     Vidya Sagar <vidyas@...dia.com>
Cc:     Bjorn Helgaas <helgaas@...nel.org>, lpieralisi@...nel.org,
        robh@...nel.org, bhelgaas@...gle.com, thierry.reding@...il.com,
        jonathanh@...dia.com, Sergey.Semin@...kalelectronics.ru,
        linux-pci@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org, kthota@...dia.com,
        mmaddireddy@...dia.com, sagar.tv@...il.com
Subject: Re: [PATCH V4] Revert "PCI: tegra194: Enable support for 256 Byte
 payload"

Hello!

[...]
> > > After commit 4fb8e46c1bc4 ("PCI: tegra194: Enable support for 256 Byte
> > > payload"), we set MPS=256 for tegra194 Root Ports.
> > > 
> > > By default (CONFIG_PCIE_BUS_DEFAULT set and no "pci=pcie_bus_*"
> > > parameter), Linux configures the MPS of every device to match the
> > > upstream bridge, which is impossible if the Root Port has MPS=256
> > > and a device only supports MPS=128.
> > 
> > Thanks for pointing out that I broke this log by omitting the mention
> > of a switch.  Is the rewording below better?  If so, Krzysztof can
> > amend the commit.
> Yes. The below rewording looks good.

Updated commit at:

  https://git.kernel.org/pci/pci/c/ebfde1584d9f

Thank you everyone!

	Krzysztof