linux-kernel - Re: Regression apparently caused by commit 088a40980efbc2c449b72f0f2c7ebd82f71d08e2 "ASoC: amd: acp: add pm ops support for acp pci driver"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6a92d9f0-dc44-4bbe-ae23-a29cb8d569aa@sirena.org.uk>
Date:   Thu, 3 Aug 2023 20:42:56 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Marian Postevca <posteuca@...ex.one>
Cc:     Syed Saba Kareem <Syed.SabaKareem@....com>,
        alsa-devel@...a-project.org, Vijendar.Mukunda@....com,
        Basavaraj.Hiregoudar@....com, Sunil-kumar.Dommati@....com,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Yang Yingliang <yangyingliang@...wei.com>,
        Venkata Prasad Potturu <venkataprasad.potturu@....com>,
        V sujith kumar Reddy <Vsujithkumar.Reddy@....com>,
        ye xingchen <ye.xingchen@....com.cn>,
        linux-kernel@...r.kernel.org
Subject: Re: Regression apparently caused by commit
 088a40980efbc2c449b72f0f2c7ebd82f71d08e2 "ASoC: amd: acp: add pm ops support
 for acp pci driver"

On Thu, Aug 03, 2023 at 10:22:07PM +0300, Marian Postevca wrote:

Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns.  Doing this makes your messages much
easier to read and reply to.

> I'm no expert in runtime power management (though I did read a bit on
> it), so I don't understand all the things that happen underneath, but
> one thing that is not clear to me is who's supposed to mark activity
> on this device and keep it from entering autosuspend if the user wants
> to play some sound? Shouldn't there be some counterpart that calls
> pm_runtime_mark_last_busy() ?  I looked through the code and can't
> find who's calling pm_runtime_mark_last_busy().

The core will hold devices out of suspend through a combination of DAPM
and PCMs being held open, it just does get and puts rather than making
an effort to use autosuspend delays.  See the calls to
pm_runtime_get_sync() in the core.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)