[<prev] [next>] [day] [month] [year] [list]
Message-ID: <CAA8EJpqdQ84wq03swhOd6Qz11QzdhBbW=r0cLNuoXsEY=vT9uA@mail.gmail.com>
Date: Fri, 4 Aug 2023 01:13:15 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Danila Tikhonov <danila@...xyga.com>
Cc: robdclark@...il.com, quic_abhinavk@...cinc.com, sean@...rly.run,
marijn.suijten@...ainline.org, airlied@...il.com, daniel@...ll.ch,
robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
conor+dt@...nel.org, konrad.dybcio@...aro.org,
neil.armstrong@...aro.org, rfoss@...nel.org, andersson@...nel.org,
quic_khsieh@...cinc.com, quic_vpolimer@...cinc.com,
quic_rmccann@...cinc.com, quic_jesszhan@...cinc.com,
liushixin2@...wei.com, linux-arm-msm@...r.kernel.org,
dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
davidwronek@...il.com
Subject: Re: [PATCH 2/2] drm/msm/dpu: Add SM7150 support
On Fri, 4 Aug 2023 at 00:13, Danila Tikhonov <danila@...xyga.com> wrote:
>
> So here too I add new sm7150_vig_sblk_0 and sm7150_vig_sblk_1 with v3lite?
>
> static const struct dpu_sspp_sub_blks sm7150_vig_sblk_0 =
> _VIG_SBLK(5, DPU_SSPP_SCALER_QSEED3LITE);
> static const struct dpu_sspp_sub_blks sm7150_vig_sblk_1 =
> _VIG_SBLK(6, DPU_SSPP_SCALER_QSEED3LITE);
Yes, please, close to other sblk variables.
But the priorities should be 4 and 5 (and 1, 2, 3 for DMA).
>
> > +static const struct dpu_sspp_cfg sm7150_sspp[] = {
> > + {
> > + .name = "sspp_0", .id = SSPP_VIG0,
> > + .base = 0x4000, .len = 0x1f0,
> > + .features = VIG_SDM845_MASK,
> > - .sblk = &sm8250_vig_sblk_0, // &sm7150_vig_sblk_0
> > + .xin_id = 0,
> > + .type = SSPP_TYPE_VIG,
> > + .clk_ctrl = DPU_CLK_CTRL_VIG0,
> > + }, {
> > + .name = "sspp_1", .id = SSPP_VIG1,
> > + .base = 0x6000, .len = 0x1f0,
> > + .features = VIG_SDM845_MASK,
> > + .sblk = &sm8250_vig_sblk_1, // &sm7150_vig_sblk_1
> > + .xin_id = 4,
> > + .type = SSPP_TYPE_VIG,
> > + .clk_ctrl = DPU_CLK_CTRL_VIG1,
> > + }, {
>
> --
> Best regards,
> Danila
>
--
With best wishes
Dmitry
Powered by blists - more mailing lists