linux-kernel - Re: [PATCH v2 4/4] media: platform: mediatek: isp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230803223034.GH9722@pendragon.ideasonboard.com>
Date:   Fri, 4 Aug 2023 01:30:34 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Julien Stephan <jstephan@...libre.com>
Cc:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Phi-bang Nguyen <pnguyen@...libre.com>,
        Florian Sylvestre <fsylvestre@...libre.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Andy Hsieh <andy.hsieh@...iatek.com>,
        Conor Dooley <conor+dt@...nel.org>,
        daoyuan huang <daoyuan.huang@...iatek.com>,
        devicetree@...r.kernel.org,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-mediatek@...ts.infradead.org, linux-media@...r.kernel.org,
        Louis Kuo <louis.kuo@...iatek.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Moudy Ho <moudy.ho@...iatek.com>,
        Ping-Hsun Wu <ping-hsun.wu@...iatek.com>,
        Rob Herring <robh+dt@...nel.org>,
        Vasily Gorbik <gor@...ux.ibm.com>
Subject: Re: [PATCH v2 4/4] media: platform: mediatek: isp_30: add mediatek
 ISP3.0 camsv

On Thu, Aug 03, 2023 at 11:53:35AM +0200, Julien Stephan wrote:
> On Mon, Jul 03, 2023 at 02:21:17PM +0200, AngeloGioacchino Del Regno wrote:
> ..snip..
> > > +
> > > +	mtk_cam_init_cfg(&cam->subdev, NULL);
> >
> > mtk_cam_init_cfg() returns an integer, and this is probably because you expect
> > it to get logic to fail: in that case, check the result of that call here,
> > otherwise, make that function void.
> >
> 
> Hi Angelo,
> 
> mtk_cam_init_cfg returns an int because it should match v4l2_subdev_pad_ops->init_cfg prototype..
> 
> mtk_cam_init does not fail, always return 0, so I though it would be ok
> to discard the return value here. What do you think?

Fine with me.

> > > +
> 
> ..snip..
> 
> > > +	unsigned int bpp;
> >
> > Can we get any format that uses a billion bits per pixel? :-P
> >
> > u8 bpp;
> 
> I am preparing the driver for futur upgrades.. in a billion years ;)

-- 
Regards,

Laurent Pinchart