[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZMsbXk4JU/Ung7qu@gmail.com>
Date: Wed, 2 Aug 2023 23:13:34 -0400
From: Guo Ren <guoren@...nel.org>
To: Haibo Xu <xiaobo55x@...il.com>
Cc: Andrew Jones <ajones@...tanamicro.com>,
Haibo Xu <haibo1.xu@...el.com>,
Paul Walmsley <paul.walmsley@...ive.com>,
Palmer Dabbelt <palmer@...belt.com>,
Albert Ou <aou@...s.berkeley.edu>,
Paolo Bonzini <pbonzini@...hat.com>,
Shuah Khan <shuah@...nel.org>,
Anup Patel <anup@...infault.org>,
Atish Patra <atishp@...shpatra.org>,
Sean Christopherson <seanjc@...gle.com>,
Vipin Sharma <vipinsh@...gle.com>,
Marc Zyngier <maz@...nel.org>,
Colton Lewis <coltonlewis@...gle.com>,
Andrew Jones <andrew.jones@...ux.dev>,
Vishal Annapurve <vannapurve@...gle.com>,
linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
kvm@...r.kernel.org, linux-kselftest@...r.kernel.org,
kvm-riscv@...ts.infradead.org
Subject: Re: [PATCH 1/4] tools: riscv: Add header file csr.h
On Wed, Aug 02, 2023 at 10:05:00AM +0800, Haibo Xu wrote:
> On Fri, Jul 28, 2023 at 5:43 PM Andrew Jones <ajones@...tanamicro.com> wrote:
> >
> > On Thu, Jul 27, 2023 at 03:20:05PM +0800, Haibo Xu wrote:
> > > Borrow some of the csr definitions and operations from kernel's
> > > arch/riscv/include/asm/csr.h to tools/ for riscv.
> >
> > You should copy the entire file verbatim.
> >
>
> Ok, will copy all the definitions in the original csr.h
Why not include the original one? Maintain the one csr.h is more
comfortable.
>
> > Thanks,
> > drew
>
Powered by blists - more mailing lists