linux-kernel - Re: [PATCH 09/15] Drivers: hv: Introduce hv_output_arg_exists in hv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZMrx5m2Tg7bfX9Ce@liuwe-devbox-debian-v2>
Date:   Thu, 3 Aug 2023 00:16:38 +0000
From:   Wei Liu <wei.liu@...nel.org>
To:     Nuno Das Neves <nunodasneves@...ux.microsoft.com>
Cc:     linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org,
        x86@...nel.org, linux-arm-kernel@...ts.infradead.org,
        linux-arch@...r.kernel.org, mikelley@...rosoft.com,
        kys@...rosoft.com, wei.liu@...nel.org, haiyangz@...rosoft.com,
        decui@...rosoft.com, ssengar@...ux.microsoft.com,
        mukeshrathor@...rosoft.com, stanislav.kinsburskiy@...il.com,
        jinankjain@...ux.microsoft.com, apais@...ux.microsoft.com,
        Tianyu.Lan@...rosoft.com, vkuznets@...hat.com, tglx@...utronix.de,
        mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com,
        hpa@...or.com, will@...nel.org, catalin.marinas@....com
Subject: Re: [PATCH 09/15] Drivers: hv: Introduce hv_output_arg_exists in
 hv_common

On Thu, Jul 27, 2023 at 12:54:44PM -0700, Nuno Das Neves wrote:
> This is a more flexible approach for determining whether to allocate the
> output page.

> This will be used in both mshv_vtl and root partition.
> 
> Signed-off-by: Nuno Das Neves <nunodasneves@...ux.microsoft.com>
> ---
>  drivers/hv/hv_common.c | 30 +++++++++++++++++++++++++-----
>  1 file changed, 25 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c
> index 99d9b262b8a7..16f069beda78 100644
> --- a/drivers/hv/hv_common.c
> +++ b/drivers/hv/hv_common.c
> @@ -57,6 +57,18 @@ EXPORT_SYMBOL_GPL(hyperv_pcpu_input_arg);
>  void * __percpu *hyperv_pcpu_output_arg;
>  EXPORT_SYMBOL_GPL(hyperv_pcpu_output_arg);
>  
> +/*
> + * Determine whether output arg is in use, for allocation/deallocation
> + */
> +static bool hv_output_arg_exists(void)
> +{
> +	bool ret = hv_root_partition ? true : false;
> +#ifdef CONFIG_MSHV_VTL
> +	ret = true;
> +#endif

This should not be here. As far as I can tell, CONFIG_MSHV_VTL is
introduced in a later patch.

The rest looks okay.

Thanks,
Wei.