linux-kernel - Re: [PATCH v3] tty: vt: Remove some repetitive initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <30b83376-0b0e-067f-ed87-a68a3c45086b@kernel.org>
Date:   Thu, 3 Aug 2023 07:20:17 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     oushixiong <oushixiong@...inos.cn>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        Samuel Thibault <samuel.thibault@...-lyon.org>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH v3] tty: vt: Remove some repetitive initialization

On 02. 08. 23, 4:20, oushixiong wrote:
> Members vc_col, vc_rows and vc_size_row of the struct vc_data have been
> initialized in visual_init(), so it no longer to initialized them again
> in vc_init().

The patch looks correct to me. The duplicated code comes from some 1.x era.

The part after the comma should be something like:
"so it is no longer needed to initialize them in vc_init() again."

> Signed-off-by: oushixiong <oushixiong@...inos.cn>

Reviewed-by: Jiri Slaby <jirislaby@...nel.org>

thanks,
-- 
js
suse labs