linux-kernel - Re: [PATCH v1] parisc: pci-dma: remove unused and dead EISA code and comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0ff53a6d-4730-1fa5-740d-93dee35c80ea@gmx.de>
Date:   Thu, 3 Aug 2023 10:04:50 +0200
From:   Helge Deller <deller@....de>
To:     Petr Tesarik <petrtesarik@...weicloud.com>,
        "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
        Hugh Dickins <hughd@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "open list:PARISC ARCHITECTURE" <linux-parisc@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Cc:     Roberto Sassu <roberto.sassu@...weicloud.com>, petr@...arici.cz
Subject: Re: [PATCH v1] parisc: pci-dma: remove unused and dead EISA code and
 comment

On 8/2/23 18:33, Petr Tesarik wrote:
> From: Petr Tesarik <petr.tesarik.ext@...wei.com>
>
> Clearly, this code isn't needed, but it gives a false positive when
> grepping the complete source tree for coherent_dma_mask.
>
> Signed-off-by: Petr Tesarik <petr.tesarik.ext@...wei.com>

queued up in parisc git tree.

Thanks!
Helge

> ---
>   arch/parisc/kernel/pci-dma.c | 8 --------
>   1 file changed, 8 deletions(-)
>
> diff --git a/arch/parisc/kernel/pci-dma.c b/arch/parisc/kernel/pci-dma.c
> index d818ece23b4a..3f6b507970eb 100644
> --- a/arch/parisc/kernel/pci-dma.c
> +++ b/arch/parisc/kernel/pci-dma.c
> @@ -417,14 +417,6 @@ void *arch_dma_alloc(struct device *dev, size_t size,
>   	map_uncached_pages(vaddr, size, paddr);
>   	*dma_handle = (dma_addr_t) paddr;
>
> -#if 0
> -/* This probably isn't needed to support EISA cards.
> -** ISA cards will certainly only support 24-bit DMA addressing.
> -** Not clear if we can, want, or need to support ISA.
> -*/
> -	if (!dev || *dev->coherent_dma_mask < 0xffffffff)
> -		gfp |= GFP_DMA;
> -#endif
>   	return (void *)vaddr;
>   }
>