linux-kernel - Re: [PATCH V6 net-next] net: mana: Configure hwc timeout from hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d87b30ae-8f4e-611c-1cb4-9fe02abd1845@intel.com>
Date:   Wed, 2 Aug 2023 18:35:36 -0700
From:   Jesse Brandeburg <jesse.brandeburg@...el.com>
To:     Souradeep Chakrabarti <schakrabarti@...ux.microsoft.com>,
        <kys@...rosoft.com>, <haiyangz@...rosoft.com>,
        <wei.liu@...nel.org>, <decui@...rosoft.com>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <longli@...rosoft.com>, <sharmaajay@...rosoft.com>,
        <leon@...nel.org>, <cai.huoqing@...ux.dev>,
        <ssengar@...ux.microsoft.com>, <vkuznets@...hat.com>,
        <tglx@...utronix.de>, <linux-hyperv@...r.kernel.org>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-rdma@...r.kernel.org>
CC:     <schakrabarti@...rosoft.com>
Subject: Re: [PATCH V6 net-next] net: mana: Configure hwc timeout from
 hardware

On 8/2/2023 4:07 AM, Souradeep Chakrabarti wrote:
> At present hwc timeout value is a fixed value. This patch sets the hwc
> timeout from the hardware. It now uses a new hardware capability
> GDMA_DRV_CAP_FLAG_1_HWC_TIMEOUT_RECONFIG to query and set the value
> in hwc_timeout.
> 
> Signed-off-by: Souradeep Chakrabarti <schakrabarti@...ux.microsoft.com>

Looks sane, thanks!

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com>

For future patches please use imperative mood for your patch
descriptions, no "This patch" [1]

[1]
https://docs.kernel.org/process/submitting-patches.html?highlight=imperative+mood#:~:text=Describe%20your%20changes%20in%20imperative%20mood%2C%20e.g.%20%22make%20xyzzy%20do%20frotz%22%20instead%20of%20%22%5BThis%20patch%5D%20makes%20xyzzy%20do%20frotz%22%20or%20%22%5BI%5D%20changed%20xyzzy%20to%20do%20frotz%22%2C%20as%20if%20you%20are%20giving%20orders%20to%20the%20codebase%20to%20change%20its%20behaviour.