linux-kernel - Re: [PATCH] mm: book3s32: add require space around that '?' and ':'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1b4a2827-8cdb-92f4-e4fd-a8623d6bf7ce@csgroup.eu>
Date:   Fri, 4 Aug 2023 16:02:14 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     "hanyu001@...suo.com" <hanyu001@...suo.com>,
        "mpe@...erman.id.au" <mpe@...erman.id.au>,
        "npiggin@...il.com" <npiggin@...il.com>,
        "Liam.Howlett@...cle.com" <Liam.Howlett@...cle.com>,
        "vbabka@...e.cz" <vbabka@...e.cz>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "dave@...olabs.net" <dave@...olabs.net>,
        "willy@...radead.org" <willy@...radead.org>
CC:     "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: book3s32: add require space around that '?' and ':'

Hello,


Le 20/07/2023 à 09:34, hanyu001@...suo.com a écrit :
> Fix below checkpatch errors:
> 
> ./arch/powerpc/mm/book3s32/tlb.c:102: ERROR: spaces required around that 
> '?' (ctx:VxW)
> ./arch/powerpc/mm/book3s32/tlb.c:102: ERROR: spaces required around that 
> ':' (ctx:VxW)


Can you please explain the purpose of those changes ? Do you use some 
tools that get disturbed by such cosmetic errors ? Otherwise what is 
your reason ?

We don't accept such standelone minor cosmetic changes at the first 
place because it looks like a waste of time.

If you have major reasons to want those changes, please re-submit with a 
details explanation in the commit message.

Thanks
Christophe

> 
> Signed-off-by: Yu Han <hanyu001@...suo.com>
> ---
>   arch/powerpc/mm/book3s32/tlb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/mm/book3s32/tlb.c 
> b/arch/powerpc/mm/book3s32/tlb.c
> index 9ad6b56bfec9..de4abfe3d06b 100644
> --- a/arch/powerpc/mm/book3s32/tlb.c
> +++ b/arch/powerpc/mm/book3s32/tlb.c
> @@ -99,7 +99,7 @@ void hash__flush_tlb_page(struct vm_area_struct *vma, 
> unsigned long vmaddr)
>       struct mm_struct *mm;
>       pmd_t *pmd;
> 
> -    mm = (vmaddr < TASK_SIZE)? vma->vm_mm: &init_mm;
> +    mm = (vmaddr < TASK_SIZE) ? vma->vm_mm : &init_mm;
>       pmd = pmd_off(mm, vmaddr);
>       if (!pmd_none(*pmd))
>           flush_hash_pages(mm->context.id, vmaddr, pmd_val(*pmd), 1);