[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0e99e131-fe4a-a672-9bfb-ad00f7dbe66a@intel.com>
Date: Fri, 4 Aug 2023 09:23:57 -0700
From: Sohil Mehta <sohil.mehta@...el.com>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
CC: <linux-kernel@...r.kernel.org>, <x86@...nel.org>,
"H. Peter Anvin" <hpa@...or.com>, Borislav Petkov <bp@...en8.de>,
Dave Hansen <dave.hansen@...ux.intel.com>,
Ingo Molnar <mingo@...hat.com>,
"Thomas Gleixner" <tglx@...utronix.de>
Subject: Re: [PATCH v2] x86/microcode: Remove microcode_mutex.
> struct cpu_info_ctx {
> @@ -488,10 +485,7 @@ static ssize_t reload_store(struct device *dev,
> if (tmp_ret != UCODE_NEW)
> goto put;
>
> - mutex_lock(µcode_mutex);
> ret = microcode_reload_late();
> - mutex_unlock(µcode_mutex);
> -
Maybe leave the new line in there before the put:? Makes it slightly
easier to read the code.
> put:
> cpus_read_unlock();
>
Anyway,
Reviewed-by: Sohil Mehta <sohil.mehta@...el.com>
Powered by blists - more mailing lists