linux-kernel - Re: [PATCH] ARM: dts: at91: sama5d29_curiosity: Add device tree for sama5d29

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 4 Aug 2023 17:28:39 +0100
From:   Conor Dooley <conor@...nel.org>
To:     Mihai Sain <mihai.sain@...rochip.com>
Cc:     claudiu.beznea@...on.dev, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        nicolas.ferre@...rochip.com, cristian.birsan@...rochip.com,
        alexandre.belloni@...tlin.com, andre.przywara@....com,
        jerry.ray@...rochip.com, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        andrei.simion@...rochip.com
Subject: Re: [PATCH] ARM: dts: at91: sama5d29_curiosity: Add device tree for
 sama5d29_curiosity board

Hey,

Firstly, $subject is missing a "v2" inside the []s.

On Fri, Aug 04, 2023 at 01:10:43PM +0300, Mihai Sain wrote:
> Add initial device tree file for sama5d29_curiosity board.
> 

> Changes in v2:
> * drop dt-bindings patch
> * remove vdd_1v8 regulator
> * fix flx4 node to use 1 spi node and pinctrl
> * add i2s0 node and pinctrl
> * remove macb0 node and pinctrl
> * remove unused pinctrl
> * sort in alphabetical order all nodes and pinctrl
> * replace "_" with "-" in node names

This needs to go under the --- line, not in the commit message.
Perhaps Claudiu would be willing to fix it, but certainly for future
versions this needs fixing.

Thanks,
Conor.

> 
> Signed-off-by: Mihai Sain <mihai.sain@...rochip.com>
> ---

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)