linux-kernel - Re: [PATCH v1 1/4] lib/vsprintf: Declare no_hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230804125534.6324f731@gandalf.local.home>
Date:   Fri, 4 Aug 2023 12:55:34 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Marco Elver <elver@...gle.com>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-kernel@...r.kernel.org, kasan-dev@...glegroups.com,
        linux-mm@...ck.org, Petr Mladek <pmladek@...e.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        Alexander Potapenko <glider@...gle.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v1 1/4] lib/vsprintf: Declare no_hash_pointers in a
 local header

On Fri, 4 Aug 2023 10:38:22 +0200
Marco Elver <elver@...gle.com> wrote:

> > +++ b/lib/vsprintf.h
> > @@ -0,0 +1,7 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +#ifndef _LIB_VSPRINTF_H
> > +#define _LIB_VSPRINTF_H
> > +
> > +extern bool no_hash_pointers;
> > +
> > +#endif  
> 
> It seems odd to create such a local header and then refer to it from
> other subsystems.
> 
> What's the downside of just putting this into the new
> include/linux/sprintf.h? If someone wants to access this variable,
> they will one way or another.

 +1

-- Steve