linux-kernel - Re: [PATCH net-next 0/3] virtchnl: fix fake 1-elem arrays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bbf73a71-7ef3-3c43-18aa-bcdeb470a125@intel.com>
Date:   Fri, 4 Aug 2023 20:09:00 +0200
From:   Alexander Lobakin <aleksander.lobakin@...el.com>
To:     Tony Nguyen <anthony.l.nguyen@...el.com>
CC:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Larysa Zaremba <larysa.zaremba@...el.com>,
        "Andy Shevchenko" <andriy.shevchenko@...ux.intel.com>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Kees Cook <keescook@...omium.org>, <netdev@...r.kernel.org>,
        <linux-hardening@...r.kernel.org>,
        <intel-wired-lan@...ts.osuosl.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 0/3] virtchnl: fix fake 1-elem arrays

From: Tony Nguyen <anthony.l.nguyen@...el.com>
Date: Fri, 4 Aug 2023 11:07:14 -0700

> On 8/4/2023 9:38 AM, Alexander Lobakin wrote:
>> From: Alexander Lobakin <aleksander.lobakin@...el.com>
>> Date: Fri, 28 Jul 2023 17:52:04 +0200
>>
>>> 6.5-rc1 started spitting warning splats when composing virtchnl
>>> messages, precisely on virtchnl_rss_key and virtchnl_lut:
>>>
>>> [   84.167709] memcpy: detected field-spanning write (size 52) of single
>>> field "vrk->key" at drivers/net/ethernet/intel/iavf/iavf_virtchnl.c:1095
>>> (size 1)
>>> [   84.169915] WARNING: CPU: 3 PID: 11 at drivers/net/ethernet/intel/
>>> iavf/iavf_virtchnl.c:1095 iavf_set_rss_key+0x123/0x140 [iavf]
>>
>> [...]
>>
>>>   .../ethernet/intel/i40e/i40e_virtchnl_pf.c    |   9 +-
>>>   drivers/net/ethernet/intel/iavf/iavf.h        |   6 +-
>>>   drivers/net/ethernet/intel/iavf/iavf_client.c |   4 +-
>>>   drivers/net/ethernet/intel/iavf/iavf_client.h |   2 +-
>>>   .../net/ethernet/intel/iavf/iavf_virtchnl.c   |  75 +++++------
>>>   drivers/net/ethernet/intel/ice/ice_virtchnl.c |   2 +-
>>>   include/linux/avf/virtchnl.h                  | 127 +++++++++++-------
>>>   7 files changed, 124 insertions(+), 101 deletions(-)
>>>
>>
>> Tony, could you please take it via your next tree? I'd like the
>> validation to make sure more different host <-> guest pairs work.
>>
>> (with Kees' tags, assuming he reviewed and approved the whole series, I
>>   asked about #2 already)
>>
>> Thanks,
>> Olek
> 
> Ok, will apply it today. For the future if you want it through IWL, can

Great, thanks!

> you tag it with the iwl-* target (and have IWL in the To)? Since this
> had 'net-next' and was 'To' netdev maintainers, I took it that you
> wanted it taken through netdev.

Sure, I know, just for some reason targeted this directly to net at
first, but then realized it would be better for this to go via IWL
:clownface:

> 
> Thanks,
> Tony

Thanks,
Olek