linux-kernel - Re: [PATCH v4 5/8] iommu/arm-smmu-v3: Refactor write_ctx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZM1eAGMxLwZWjt96@Asurada-Nvidia>
Date:   Fri, 4 Aug 2023 13:22:24 -0700
From:   Nicolin Chen <nicolinc@...dia.com>
To:     Michael Shavit <mshavit@...gle.com>
CC:     <iommu@...ts.linux.dev>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <will@...nel.org>,
        <robin.murphy@....com>, <jgg@...dia.com>,
        <jean-philippe@...aro.org>
Subject: Re: [PATCH v4 5/8] iommu/arm-smmu-v3: Refactor write_ctx_desc

On Thu, Aug 03, 2023 at 12:32:33AM +0800, Michael Shavit wrote:

> -       ret = arm_smmu_write_ctx_desc(smmu_domain, mm->pasid, cd);
> -       if (ret)
> +       ret = arm_smmu_write_ctx_desc_devices(smmu_domain, mm->pasid, cd);
> +       if (ret) {
> +               arm_smmu_write_ctx_desc_devices(smmu_domain, mm->pasid, NULL);
>                 goto err_put_notifier;

There are a couple of places calling this helper but they don't
check the return code. Not sure if they should check too and do
a fallback like this: if so, this fallback can be squashed into
the helper; otherwise, this should be fine. Anyway, if there is
a need of change for those, it would need another patch I think.

Reviewed-by: Nicolin Chen <nicolinc@...dia.com>