linux-kernel - Re: [PATCH v4 4/8] iommu/arm-smmu-v3: move stall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 4 Aug 2023 16:32:27 -0700
From:   Nicolin Chen <nicolinc@...dia.com>
To:     Michael Shavit <mshavit@...gle.com>
CC:     <iommu@...ts.linux.dev>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <will@...nel.org>,
        <robin.murphy@....com>, <jgg@...dia.com>,
        <jean-philippe@...aro.org>
Subject: Re: [PATCH v4 4/8] iommu/arm-smmu-v3: move stall_enabled to the cd
 table

On Thu, Aug 03, 2023 at 12:32:32AM +0800, Michael Shavit wrote:

> This controls whether CD entries will have the stall bit set when
> writing entries into the table.

It'd be nicer to spare a few more lines here -- something like
this yet feel free to rephrase:

The stall bit of a CD entry should follow the master->stall_enabled and
has an inverse relationship with the STE.S1STALLD bit.

Also, a domain should be able to share between two masters, even if they
have different stall_enabled configurations, in which case, two masters
should have two sets of CD tables, i.e. having two different CD entries
for the same domain holding a CD.

So, move the "stall_enabled" out of domain to cd_table. It then controls
whether CD entries will have the stall bit set when writing entries into
the table.

> Signed-off-by: Michael Shavit <mshavit@...gle.com>
> Reviewed-by: Jason Gunthorpe <jgg@...dia.com>

With that,
Reviewed-by: Nicolin Chen <nicolinc@...dia.com>

And btw, you should probably put your Signed-off-by at the end
the commit log, i.e. behind "Reviewed-by", meaning you created/
updated the commit, and then signed it off.

Nicolin