linux-kernel - Re: [RFC PATCH net-next 2/6] net/smc: add vendor unique experimental options area in clc handshake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4de725f9-6bc6-b150-c6cd-1bc185edc145@linux.alibaba.com>
Date:   Fri, 4 Aug 2023 12:02:03 +0800
From:   Guangguan Wang <guangguan.wang@...ux.alibaba.com>
To:     Simon Horman <horms@...nel.org>
Cc:     wenjia@...ux.ibm.com, jaka@...ux.ibm.com, kgraul@...ux.ibm.com,
        tonylu@...ux.alibaba.com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, alibuda@...ux.alibaba.com,
        guwen@...ux.alibaba.com, linux-s390@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH net-next 2/6] net/smc: add vendor unique experimental
 options area in clc handshake


I will fix it in the next version.

Thanks, 
Guangguan Wang

On 2023/8/4 01:45, Simon Horman wrote:
> On Thu, Aug 03, 2023 at 09:24:18PM +0800, Guangguan Wang wrote:
> 
> ...
> 
> Hi Guangguan Wang,
> 
>> @@ -987,12 +991,12 @@ static int smc_clc_send_confirm_accept(struct smc_sock *smc,
>>  {
>>  	struct smc_connection *conn = &smc->conn;
>>  	struct smc_clc_msg_accept_confirm *clc;
>> -	struct smc_clc_first_contact_ext fce;
>> +	struct smc_clc_first_contact_ext_v2x fce;
>>  	struct smc_clc_fce_gid_ext gle;
>>  	struct smc_clc_msg_trail trl;
>>  	struct kvec vec[5];
>>  	struct msghdr msg;
>> -	int i, len;
>> +	int i, len, fce_len;
> 
> Please preserve reverse xmas tree - longest line to shortest -
> for local variable declarations: this is Networking code.
> 
> https://github.com/ecree-solarflare/xmastree is your friend here.
> 
> ...