linux-kernel - Re: [PATCH v3] ext4: fix memory leaks in ext4_fname_{setup_filename,prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230804040652.GA1954@sol.localdomain>
Date:   Thu, 3 Aug 2023 21:06:52 -0700
From:   Eric Biggers <ebiggers@...nel.org>
To:     Luís Henriques <lhenriques@...e.de>
Cc:     Theodore Ts'o <tytso@....edu>,
        Andreas Dilger <adilger.kernel@...ger.ca>,
        Daniel Rosenberg <drosen@...gle.com>,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] ext4: fix memory leaks in
 ext4_fname_{setup_filename,prepare_lookup}

On Thu, Aug 03, 2023 at 10:17:13AM +0100, Luís Henriques wrote:
> If the filename casefolding fails, we'll be leaking memory from the
> fscrypt_name struct, namely from the 'crypto_buf.name' member.
> 
> Make sure we free it in the error path on both ext4_fname_setup_filename()
> and ext4_fname_prepare_lookup() functions.
> 
> Fixes: 1ae98e295fa2 ("ext4: optimize match for casefolded encrypted dirs")
> Signed-off-by: Luís Henriques <lhenriques@...e.de>
> ---
> Changes since v2:
> - Rephrased commit log to (hopefully!) make it more clear.
> - Use ext4_fname_free_filename() instead of fscrypt_free_filename().
>   Although not strictly needed, it cleans up the fname struct, removing a
>   dangling pointer to freed memory.
> 
> Changes since v1:
> - Include fix to ext4_fname_prepare_lookup() as well
> - Add 'Fixes:' tag
> 
>  fs/ext4/crypto.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/fs/ext4/crypto.c b/fs/ext4/crypto.c
> index e20ac0654b3f..453d4da5de52 100644
> --- a/fs/ext4/crypto.c
> +++ b/fs/ext4/crypto.c
> @@ -33,6 +33,8 @@ int ext4_fname_setup_filename(struct inode *dir, const struct qstr *iname,
>  
>  #if IS_ENABLED(CONFIG_UNICODE)
>  	err = ext4_fname_setup_ci_filename(dir, iname, fname);
> +	if (err)
> +		ext4_fname_free_filename(fname);
>  #endif
>  	return err;
>  }
> @@ -51,6 +53,8 @@ int ext4_fname_prepare_lookup(struct inode *dir, struct dentry *dentry,
>  
>  #if IS_ENABLED(CONFIG_UNICODE)
>  	err = ext4_fname_setup_ci_filename(dir, &dentry->d_name, fname);
> +	if (err)
> +		ext4_fname_free_filename(fname);
>  #endif
>  	return err;
>  }

Reviewed-by: Eric Biggers <ebiggers@...gle.com>

- Eric