linux-kernel - Re: [PATCH] crypto: caam: use dma align for crypt tfm ctx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZMyAFINQvlbk+MYF@gondor.apana.org.au>
Date:   Fri, 4 Aug 2023 12:35:32 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Gaurav Jain <gaurav.jain@....com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Varun Sethi <V.Sethi@....com>,
        Meenakshi Aggarwal <meenakshi.aggarwal@....com>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: caam: use dma align for crypt tfm ctx

On Thu, Aug 03, 2023 at 03:59:01PM +0530, Gaurav Jain wrote:
> enginectx is not set when use crypto_tfm_ctx.
> fixing this by modifying to crypto_tfm_ctx_dma
> 
> Fixes: 4cb4f7c11dee ("crypto: caam - Set DMA alignment explicitly")
> Signed-off-by: Gaurav Jain <gaurav.jain@....com>
> ---
>  crypto/crypto_engine.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for catching this.  Unfortunately this fix will break other
drivers that do not use ctx_dma.

I'll try to fix by getting rid of enginectx.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt