[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2e781d29087b40bdf2c04a1fe11206986ff01ca8.camel@mediatek.com>
Date: Fri, 4 Aug 2023 07:08:01 +0000
From: Maso Huang (黃加竹)
<Maso.Huang@...iatek.com>
To: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-mediatek@...ts.infradead.org"
<linux-mediatek@...ts.infradead.org>,
"robh+dt@...nel.org" <robh+dt@...nel.org>,
"chenxiangrui@...qin.corp-partner.google.com"
<chenxiangrui@...qin.corp-partner.google.com>,
Trevor Wu (吳文良) <Trevor.Wu@...iatek.com>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"krzysztof.kozlowski@...aro.org" <krzysztof.kozlowski@...aro.org>,
"broonie@...nel.org" <broonie@...nel.org>,
Allen-KH Cheng (程冠勲)
<Allen-KH.Cheng@...iatek.com>,
"conor+dt@...nel.org" <conor+dt@...nel.org>,
"tiwai@...e.com" <tiwai@...e.com>,
"lgirdwood@...il.com" <lgirdwood@...il.com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"krzysztof.kozlowski+dt@...aro.org"
<krzysztof.kozlowski+dt@...aro.org>,
"matthias.bgg@...il.com" <matthias.bgg@...il.com>,
"perex@...ex.cz" <perex@...ex.cz>, "arnd@...db.de" <arnd@...db.de>,
"angelogioacchino.delregno@...labora.com"
<angelogioacchino.delregno@...labora.com>,
"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>
Subject: Re: [PATCH v3 5/6] ASoC: dt-bindings: mediatek,mt7986-wm8960: add
mt7986-wm8960 document
On Mon, 2023-07-31 at 16:56 +0200, Krzysztof Kozlowski wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> On 31/07/2023 10:14, Krzysztof Kozlowski wrote:
> >>>> + mediatek,audio-codec:
> >>>> + $ref: /schemas/types.yaml#/definitions/phandle
> >>>> + description: The phandle of wm8960 codec.
> >>>> +
> >>>
> >>> How did you implement Rob's comment? Or did you just ignore it?
> >>>
> >>> Best regards,
> >>> Krzysztof
> >>>
> >>
> >> Hi Krzysztof,
> >>
> >> Sorry, I did not mean to ignore Rob's comment.
> >> I waited for some suggestion in mail below, but it seems Rob was a
> >> little busy.
> >>
> >>
> https://lore.kernel.org/lkml/8c6316e79e40406e4d46709f602dcb14a4c00562.camel@mediatek.com/
> >>
> >> After gentle ping last week and receiving your advice, I thought
> that
> >> means to send the v3 patch and might discuss dtbingding in v3
> series.
> >>
> >> So sorry for misunderstanding it, I'll check the details with Rob
> in v3
> >> series then refine it in v4.
> >
> > The problem is that you did not reference in this patch any ongoing
> > discussion and further questions, so comment looks like addressed,
> while
> > it was not.
> >
> > Rob said:
> > "in a common schema and reference them "
> > You said:
> > "common part yaml and reference to it"
> > so I think you both agreed on the same.
> >
> > The advice would be to create common binding which is then
> referenced by
> > other and your bindings. However if you start doing it, you will
> notice
> > that it is impossible, because you have conflicting types for
> > "audio-codec", so you cannot have one definition.
> >
> > This leads to the point - property is probably wrong and you need
> > dai-link with sound-dai property, just like most cards are doing.
>
> BTW, might be useful for you, just sent:
>
https://lore.kernel.org/linux-devicetree/20230731094303.185067-1-krzysztof.kozlowski@linaro.org/T/#t
>
> Anyway you need dai-links, I think.
>
> Best regards,
> Krzysztof
>
Hi Krzysztof,
Thanks for your useful info!
I'll reference to sound-card-common.yaml for audio-routing.
For mediatek,platform and mediatek,audio-codec, I would like to replace
them with cpu and codec as properties directly like below.
cpu {
sound-dai <&ate>;
};
codec {
sound-dai <&wm8960>;
};
Is that OK?
Best regards,
Maso
Powered by blists - more mailing lists