linux-kernel - Re: [PATCH 1/7] crypto: hisilicon/qm - obtain the mailbox configuration at one time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZMy2LQckr/OtS1ZG@gondor.apana.org.au>
Date:   Fri, 4 Aug 2023 16:26:21 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Weili Qian <qianweili@...wei.com>
Cc:     linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        liulongfang@...wei.com
Subject: Re: [PATCH 1/7] crypto: hisilicon/qm - obtain the mailbox
 configuration at one time

On Sat, Jul 29, 2023 at 08:52:33PM +0800, Weili Qian wrote:
> The mailbox configuration(128 bits) needs to be obtained from the
> hardware at one time. If the mailbox configuration is obtained for
> multiple times, the read value may be incorrect. Use the instruction
> to read mailbox data instead of readl().
> 
> Signed-off-by: Weili Qian <qianweili@...wei.com>

Your patch description makes no sense to me.  Please explain more
clearly why you're replacing generic IO primitives with hand-rolled
assembly.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt