linux-kernel - Re: [PATCH] kthread: unexport __kthread_should

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 4 Aug 2023 01:39:22 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, John Stultz <jstultz@...gle.com>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Arve Hjønnevåg <arve@...roid.com>,
        Valentin Schneider <vschneid@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Christian Brauner (Microsoft)" <brauner@...nel.org>,
        Mike Christie <michael.christie@...cle.com>,
        Nicholas Piggin <npiggin@...il.com>,
        Zqiang <qiang1.zhang@...el.com>,
        Prathu Baronia <quic_pbaronia@...cinc.com>,
        Sami Tolvanen <samitolvanen@...gle.com>
Subject: Re: [PATCH] kthread: unexport __kthread_should_park()

On Fri, Aug 04, 2023 at 08:41:51AM +0200, Greg Kroah-Hartman wrote:
> There are no in-kernel users of __kthread_should_park() so mark it as
> static and do not export it.
> 
> Cc: John Stultz <jstultz@...gle.com>
> Cc: "Peter Zijlstra (Intel)" <peterz@...radead.org>
> Cc: "Arve Hjønnevåg" <arve@...roid.com>
> Cc: Valentin Schneider <vschneid@...hat.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: "Christian Brauner (Microsoft)" <brauner@...nel.org>
> Cc: Mike Christie <michael.christie@...cle.com>
> Cc: Kees Cook <keescook@...omium.org>
> Cc: Nicholas Piggin <npiggin@...il.com>
> Cc: Zqiang <qiang1.zhang@...el.com>
> Cc: Prathu Baronia <quic_pbaronia@...cinc.com>
> Cc: Sami Tolvanen <samitolvanen@...gle.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Yeah. Seems like it got an EXPORT because it was duplicating the
neighboring functions?

Reviewed-by: Kees Cook <keescook@...omium.org>

-- 
Kees Cook