linux-kernel - Re: [PATCH v2 17/23] firmware: Explicitly include correct DT includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20230804095127.w74m6aphiwkaqlim@bogus>
Date:   Fri, 4 Aug 2023 10:51:27 +0100
From:   Sudeep Holla <sudeep.holla@....com>
To:     Rob Herring <robh@...nel.org>
Cc:     soc@...nel.org, Patrice Chotard <patrice.chotard@...s.st.com>,
        Tsahee Zidenberg <tsahee@...apurnalabs.com>,
        Antoine Tenart <atenart@...nel.org>,
        Jisheng Zhang <jszhang@...nel.org>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Gregory Clement <gregory.clement@...tlin.com>,
        Jean-Marie Verdun <verdun@....com>,
        Nick Hawkins <nick.hawkins@....com>,
        Lubomir Rintel <lkundrak@...sk>,
        Linus Walleij <linus.walleij@...aro.org>,
        Avi Fishman <avifishman70@...il.com>,
        Tomer Maimon <tmaimon77@...il.com>,
        Tali Perry <tali.perry1@...il.com>,
        Patrick Venture <venture@...gle.com>,
        Nancy Yuen <yuenn@...gle.com>,
        Benjamin Fair <benjaminfair@...gle.com>,
        Daniel Mack <daniel@...que.org>,
        Haojian Zhuang <haojian.zhuang@...il.com>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        Heiko Stuebner <heiko@...ech.de>,
        Liviu Dudau <liviu.dudau@....com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Viresh Kumar <vireshk@...nel.org>,
        Sh iraz Has him <shiraz.linux.kernel@...il.com>,
        Stuart Yoder <stuyoder@...il.com>,
        Laurentiu Tudor <laurentiu.tudor@....com>,
        Jay Fang <f.fangjian@...wei.com>, Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Samuel Holland <samuel@...lland.org>,
        Cristian Marussi <cristian.marussi@....com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Florian Fainelli <florian.fainelli@...adcom.com>,
        Dinh Nguyen <dinguyen@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Michal Simek <michal.simek@....com>,
        Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...id.au>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Li Yang <leoyang.li@....com>, Qiang Zhao <qiang.zhao@....com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        openbmc@...ts.ozlabs.org, linux-rockchip@...ts.infradead.org,
        linux-sunxi@...ts.linux.dev, linux-mediatek@...ts.infradead.org,
        linux-rpi-kernel@...ts.infradead.org, linux-tegra@...r.kernel.org,
        linux-aspeed@...ts.ozlabs.org, linux-pm@...r.kernel.org,
        Thierry Reding <treding@...dia.com>
Subject: Re: [PATCH v2 17/23] firmware: Explicitly include correct DT includes

On Thu, Aug 03, 2023 at 04:42:57PM -0600, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
> 
> Acked-by: Dinh Nguyen <dinguyen@...nel.org>
> Acked-by: Thierry Reding <treding@...dia.com>
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
>  drivers/firmware/arm_scmi/driver.c | 4 ++--
>  drivers/firmware/scpi_pm_domain.c  | 3 ++-

(For SCMI changes)

Acked-by:  Sudeep Holla <sudeep.holla@....com>

-- 
Regards,
Sudeep