linux-kernel - Re: [PATCH v10 3/3] ublk: enable zoned storage support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 04 Aug 2023 10:59:03 +0200
From:   "Andreas Hindborg (Samsung)" <nmi@...aspace.dk>
To:     Johannes Thumshirn <Johannes.Thumshirn@....com>
Cc:     Ming Lei <ming.lei@...hat.com>,
        "hch@...radead.org" <hch@...radead.org>,
        "gost.dev@...sung.com" <gost.dev@...sung.com>,
        "open list:BLOCK LAYER" <linux-block@...r.kernel.org>,
        Hans Holmberg <Hans.Holmberg@....com>,
        Matias Bjørling <Matias.Bjorling@....com>,
        Minwoo Im <minwoo.im.dev@...il.com>,
        Jens Axboe <axboe@...nel.dk>,
        Johannes Thumshirn <jth@...nel.org>,
        Aravind Ramesh <Aravind.Ramesh@....com>,
        Damien Le Moal <dlemoal@...nel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v10 3/3] ublk: enable zoned storage support


Johannes Thumshirn <Johannes.Thumshirn@....com> writes:

> On 03.08.23 16:09, Andreas Hindborg (Samsung) wrote:
>> + buf = __vmalloc(bufsize, GFP_KERNEL | __GFP_NORETRY);
>
> Missing #include <linux/vmalloc.h> so the bot doesn't complain.

Thanks, gotta add that so code compiles for Sega Dreamcast!

> But while we're at it, why can't you just use kvmalloc() here?

I don't see why not. It should be better for small reports I guess. I will change it.

BR Andreas