[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <f71a8729-57a8-f45f-7db2-41ab543405de@wolfvision.net>
Date: Fri, 4 Aug 2023 13:24:46 +0200
From: Michael Riesch <michael.riesch@...fvision.net>
To: neil.armstrong@...aro.org, Sam Ravnborg <sam@...nborg.org>,
David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Maxime Ripard <mripard@...nel.org>,
Miquel Raynal <miquel.raynal@...tlin.com>,
Sebastian Reichel <sre@...nel.org>,
Gerald Loacker <gerald.loacker@...fvision.net>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/3] drm/panel: sitronix-st7789v: add panel orientation
support
Hi Neil,
On 8/4/23 10:40, Neil Armstrong wrote:
> Hi,
>
> On 03/08/2023 22:13, Michael Riesch wrote:
>> Determine the orientation of the display based on the device tree and
>> propagate it.
>>
>> Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>
>> Signed-off-by: Michael Riesch <michael.riesch@...fvision.net>
>> ---
>> drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 18 ++++++++++++++++++
>> 1 file changed, 18 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
>> b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
>> index c7cbfe6ca82c..6575f07d49e3 100644
>> --- a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
>> +++ b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
>> @@ -116,6 +116,7 @@ struct st7789v {
>> struct spi_device *spi;
>> struct gpio_desc *reset;
>> struct regulator *power;
>> + enum drm_panel_orientation orientation;
>> };
>> enum st7789v_prefix {
>> @@ -170,6 +171,7 @@ static const struct drm_display_mode default_mode = {
>> static int st7789v_get_modes(struct drm_panel *panel,
>> struct drm_connector *connector)
>> {
>> + struct st7789v *ctx = panel_to_st7789v(panel);
>> struct drm_display_mode *mode;
>> mode = drm_mode_duplicate(connector->dev, &default_mode);
>> @@ -188,9 +190,22 @@ static int st7789v_get_modes(struct drm_panel
>> *panel,
>> connector->display_info.width_mm = 61;
>> connector->display_info.height_mm = 103;
>> + /*
>> + * TODO: Remove once all drm drivers call
>> + * drm_connector_set_orientation_from_panel()
>> + */
>> + drm_connector_set_panel_orientation(connector, ctx->orientation);
>> +
>> return 1;
>> }
>> +static enum drm_panel_orientation st7789v_get_orientation(struct
>> drm_panel *p)
>> +{
>> + struct st7789v *ctx = panel_to_st7789v(p);
>> +
>> + return ctx->orientation;
>> +}
>> +
>> static int st7789v_prepare(struct drm_panel *panel)
>> {
>> struct st7789v *ctx = panel_to_st7789v(panel);
>> @@ -349,6 +364,7 @@ static const struct drm_panel_funcs
>> st7789v_drm_funcs = {
>> .disable = st7789v_disable,
>> .enable = st7789v_enable,
>> .get_modes = st7789v_get_modes,
>> + .get_orientation = st7789v_get_orientation,
>> .prepare = st7789v_prepare,
>> .unprepare = st7789v_unprepare,
>> };
>> @@ -382,6 +398,8 @@ static int st7789v_probe(struct spi_device *spi)
>> if (ret)
>> return ret;
>> + of_drm_get_panel_orientation(spi->dev.of_node, &ctx->orientation);
>> +
>> drm_panel_add(&ctx->panel);
>> return 0;
>>
>
> This patch doesn't apply clean on drm-misc-next, could you rebase and
> resend ?
Sure! v3 is out.
Best regards,
Michael
>
> Thanks,
> Neil
Powered by blists - more mailing lists