linux-kernel - Re: [PATCH v11 2/3] ublk: move check for empty address field on command submission

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACVXFVP1x7dRfHTFvM7ah9iB41E-5nxp=r16xr580UVJ_PRKUQ@mail.gmail.com>
Date:   Fri, 4 Aug 2023 21:32:38 +0800
From:   Ming Lei <tom.leiming@...il.com>
To:     "Andreas Hindborg (Samsung)" <nmi@...aspace.dk>
Cc:     Ming Lei <ming.lei@...hat.com>,
        Aravind Ramesh <Aravind.Ramesh@....com>,
        Christoph Hellwig <hch@...radead.org>, gost.dev@...sung.com,
        Minwoo Im <minwoo.im.dev@...il.com>,
        Hans Holmberg <Hans.Holmberg@....com>,
        Matias Bjorling <Matias.Bjorling@....com>,
        Damien Le Moal <dlemoal@...nel.org>,
        Andreas Hindborg <a.hindborg@...sung.com>,
        Johannes Thumshirn <jth@...nel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Jens Axboe <axboe@...nel.dk>,
        "open list:BLOCK LAYER" <linux-block@...r.kernel.org>
Subject: Re: [PATCH v11 2/3] ublk: move check for empty address field on
 command submission

On Fri, Aug 4, 2023 at 8:34 PM Andreas Hindborg (Samsung)
<nmi@...aspace.dk> wrote:
>
> From: Andreas Hindborg <a.hindborg@...sung.com>
>
> In preparation for zoned storage support, move the check for empty `addr`
> field into the command handler case statement. Note that the check makes no
> sense for `UBLK_IO_NEED_GET_DATA` because the `addr` field must always be
> set for this command.
>
> Signed-off-by: Andreas Hindborg <a.hindborg@...sung.com>

Reviewed-by: Ming Lei <ming.lei@...hat.com>

Thanks,