linux-kernel - Re: [PATCH v2] staging: vme_user: fix check alignment should match open parenthesis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 4 Aug 2023 11:07:36 -0300
From:   Alexon Oliveira <alexondunkan@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     martyn@...chs.me.uk, manohar.vanga@...il.com,
        linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev,
        dan.carpenter@...aro.org
Subject: Re: [PATCH v2] staging: vme_user: fix check alignment should match
 open parenthesis

On Fri, Aug 04, 2023 at 03:23:17PM +0200, Greg KH wrote:
> On Tue, Aug 01, 2023 at 01:17:07PM -0300, Alexon Oliveira wrote:
> > First patch was intended to fix all "CHECK: Alignment should match open parenthesis",
> > but added new warnings in the process. This patch is intended to fixed them all,
> > on lines 133, 142, 144, 145 and 173.
> 
> Patches are stand-alone, we have no idea what "First patch" is.
>

That was just me being verbose and given more details related to the
v1 of this patch. I apologize. Nevermind that. What is worth is below
the ---

> Please look at the commit log for this file, or for all of
> drivers/staging:
> 	git log drivers/staging/
> and get an idea of what changelog text should look like.
> 

ACK. So the correct changelog should be:

staging: vme_user: fix check alignment should match open parenthesis

Fixed the following as reported by checkpatch to adhere to the
Linux kernel coding-style guidelines.

Changes in v2:
- Fixed CHECK: line length exceeds 100 columns, noted by Greg KH and Dan Carpenter
- Fixed CHECK: Alignment should match open parenthesis
- Fixed CHECK: Lines should not end with a '('

Changes in v1:
- Fixed CHECK: Alignment should match open parenthesis

Signed-off-by: Alexon Oliveira <alexondunkan@...il.com>

> 
> thanks,
> 
> greg k-h

Thank you.

Alexon Oliveira