linux-kernel - Re: XFS metadata CRC errors on zram block device on ppc64le architecture

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <273c9c99-dc2f-2854-bbc1-70b22b5589d8@suse.de>
Date:   Fri, 4 Aug 2023 16:20:07 +0200
From:   Hannes Reinecke <hare@...e.de>
To:     Christoph Hellwig <hch@....de>,
        Sergey Senozhatsky <senozhatsky@...omium.org>
Cc:     Dusty Mabe <dusty@...tymabe.com>, wq@....de,
        Minchan Kim <minchan@...nel.org>, Jens Axboe <axboe@...nel.dk>,
        linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>, marmijo@...hat.com
Subject: Re: XFS metadata CRC errors on zram block device on ppc64le
 architecture

On 8/4/23 15:42, Christoph Hellwig wrote:
> FYI, I've found an arm64 system with 16k page size support, and while
> I can't reproduce the exact issue, I do see corruption with I/O test
> on zram that don't show on the same system with 4k pages.  I'm trying
> to understand the details at the moment.
> 
For some reason zram run with a logical block size of 4k:

#define ZRAM_LOGICAL_BLOCK_SHIFT 12
#define ZRAM_LOGICAL_BLOCK_SIZE (1 << ZRAM_LOGICAL_BLOCK_SHIFT)

so we'll have sub-page accesses for larger page sizes.
My bet is that the issue goes away if we set the logical block size to 
page size ...

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@...e.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman