linux-kernel - Re: [PATCH] extcon: cht_wc: add POWER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 4 Aug 2023 16:42:09 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Arnd Bergmann <arnd@...nel.org>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Sebastian Reichel <sebastian.reichel@...labora.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Alvin Šipraga <alsi@...g-olufsen.dk>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Marek Vasut <marex@...x.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] extcon: cht_wc: add POWER_SUPPLY dependency

Hi,

On 8/4/23 15:28, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The driver fails to link when CONFIG_POWER_SUPPLY is disabled:
> 
> x86_64-linux-ld: vmlinux.o: in function `cht_wc_extcon_psy_get_prop':
> extcon-intel-cht-wc.c:(.text+0x15ccda7): undefined reference to `power_supply_get_drvdata'
> x86_64-linux-ld: vmlinux.o: in function `cht_wc_extcon_pwrsrc_event':
> extcon-intel-cht-wc.c:(.text+0x15cd3e9): undefined reference to `power_supply_changed'
> x86_64-linux-ld: vmlinux.o: in function `cht_wc_extcon_probe':
> extcon-intel-cht-wc.c:(.text+0x15cd596): undefined reference to `devm_power_supply_register'
> 
> It should be possible to change the driver to not require this at
> compile time and still provide other functions, but adding a hard
> Kconfig dependency does not seem to have any practical downsides
> and is simpler since the option is normally enabled anyway.
> 
> Fixes: 66e31186cd2aa ("extcon: intel-cht-wc: Add support for registering a power_supply class-device")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans


> ---
>  drivers/extcon/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> index 0ef1971d22bb0..8de9023c2a387 100644
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -62,6 +62,7 @@ config EXTCON_INTEL_CHT_WC
>  	tristate "Intel Cherrytrail Whiskey Cove PMIC extcon driver"
>  	depends on INTEL_SOC_PMIC_CHTWC
>  	depends on USB_SUPPORT
> +	depends on POWER_SUPPLY
>  	select USB_ROLE_SWITCH
>  	help
>  	  Say Y here to enable extcon support for charger detection / control