linux-kernel - Re: [PATCH v1] clk: keystone: syscon-clk: Fix audio refclk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dd80b41a26c62ba42efc51d9ab800bfb.sboyd@kernel.org>
Date:   Fri, 04 Aug 2023 18:12:57 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Francesco Dolcini <francesco@...cini.it>,
        Jai Luthra <j-luthra@...com>,
        Michael Turquette <mturquette@...libre.com>,
        Santosh Shilimkar <ssantosh@...nel.org>
Cc:     Francesco Dolcini <francesco.dolcini@...adex.com>,
        linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH v1] clk: keystone: syscon-clk: Fix audio refclk

Quoting Francesco Dolcini (2023-07-28 15:26:39)
> From: Francesco Dolcini <francesco.dolcini@...adex.com>
> 
> Audio REFCLK's are not working correctly, trying to use them lead to the
> following errors:
> 
> [    6.575277] of_clk_hw_onecell_get: invalid index 4294934528
> [    6.581515] wm8904 1-001a: Failed to get MCLK
> [    6.586290] wm8904: probe of 1-001a failed with error -2
> 
> The issue is that Audio REFCLK has #clock-cells = 0 [1], while the driver
> is registering those clocks assuming they have one cells. Fix this by
> registering the clock with of_clk_hw_simple_get() when there is only one
> instance, e.g. "audio_refclk".
> 
> [1] Documentation/devicetree/bindings/clock/ti,am62-audio-refclk.yaml
> 
> Fixes: 6acab96ee337 ("clk: keystone: syscon-clk: Add support for audio refclk")
> Signed-off-by: Francesco Dolcini <francesco.dolcini@...adex.com>
> ---

Applied to clk-fixes