[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CANiq72mkmTRzuYSGveP2xxPbDJELHXoVWVbKF2eyK0DhJ+y7bw@mail.gmail.com>
Date: Sat, 5 Aug 2023 12:46:18 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Martin Rodriguez Reboredo <yakoyoku@...il.com>
Cc: Miguel Ojeda <ojeda@...nel.org>,
Alex Gaynor <alex.gaynor@...il.com>,
Wedson Almeida Filho <wedsonaf@...il.com>,
Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
Björn Roy Baron <bjorn3_gh@...tonmail.com>,
Benno Lossin <benno.lossin@...ton.me>,
rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] scripts: generate_rust_analyzer: provide `cfg`s for
`core` and `alloc`
On Fri, Aug 4, 2023 at 7:14 PM Martin Rodriguez Reboredo
<yakoyoku@...il.com> wrote:
>
> Suggested-by: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Thanks Martin!
I am a bit confused about the Suggested-by -- did you add it due to
the suggestion from v1 of passing variables via command-line
arguments? If so, I appreciate the gesture, but the main idea/report
(passing the missing `cfg`s for `core` and `alloc`) is yours! :)
The patch seems fine, I will test & apply it soon. If someone wants to
give it a Tested-by with rust-analyzer, that would be great too,
thanks! (note: it applies on top of `rust-next`).
Cheers,
Miguel
Powered by blists - more mailing lists