linux-kernel - Re: [PATCH] net: tipc: add net device refcount tracker for bearer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZM4yAOKtdcTBXQQY@vergenet.net>
Date:   Sat, 5 Aug 2023 13:26:56 +0200
From:   Simon Horman <horms@...nel.org>
To:     yang.yang29@....com.cn
Cc:     jmaloy@...hat.com, davem@...emloft.net, ying.xue@...driver.com,
        edumazet@...gle.com, kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: tipc: add net device refcount tracker for bearer

On Fri, Aug 04, 2023 at 04:53:41PM +0800, yang.yang29@....com.cn wrote:
> From: xu xin <xu.xin16@....com.cn>
> 
> Add net device refcount tracker to the struct tipc_bearer.
> 
> Signed-off-by: xu xin <xu.xin16@....com.cn>
> Reviewed-by: Yang Yang <yang.yang.29@....com.cn>
> Cc: Kuang Mingfu <kuang.mingfu@....com.cn>

...

> @@ -479,7 +479,7 @@ void tipc_disable_l2_media(struct tipc_bearer *b)
>  	dev_remove_pack(&b->pt);
>  	RCU_INIT_POINTER(dev->tipc_ptr, NULL);
>  	synchronize_net();
> -	dev_put(dev);
> +	netdev_put(dev, &b->devtracker);
>  }
> 
>  /**
> diff --git a/net/tipc/bearer.h b/net/tipc/bearer.h
> index 41eac1ee0c09..1adeaf94aa62 100644
> --- a/net/tipc/bearer.h
> +++ b/net/tipc/bearer.h
> @@ -174,6 +174,7 @@ struct tipc_bearer {
>  	u16 encap_hlen;
>  	unsigned long up;
>  	refcount_t refcnt;
> +	netdevice_tracker	devtracker;

Hi Xu Xin and Yang Yang,

Please add netdevice_tracker to the kernel doc for struct tipc_bearer,
which appears just above the definition of the structure.

>  };
> 
>  struct tipc_bearer_names {

With that fixed, feel free to add:

Reviewed-by: Simon Horman <horms@...nel.org>

-- 
pw-bot: changes-requested