linux-kernel - Re: [PATCH 1/3] bus: ti-sysc: Fix build warning for 64-bit build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230805172325.4vjb4lb3vtu3dgfe@commodity>
Date:   Sat, 5 Aug 2023 12:23:25 -0500
From:   Nishanth Menon <nm@...com>
To:     Dhruva Gole <d-gole@...com>
CC:     Tony Lindgren <tony@...mide.com>, <linux-omap@...r.kernel.org>,
        "Dave Gerlach" <d-gerlach@...com>, Faiz Abbas <faiz_abbas@...com>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        Keerthy <j-keerthy@...com>,
        "Kevin Hilman" <khilman@...libre.com>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 1/3] bus: ti-sysc: Fix build warning for 64-bit build

On 10:47-20230805, Dhruva Gole wrote:
> Hi Tony,
> 
> On Aug 04, 2023 at 13:38:57 +0300, Tony Lindgren wrote:
> > Fix "warning: cast from pointer to integer of different size" on 64-bit
> > builds.
> 
> Thanks for enabling this on 64 bit, will help us in K3 SOCs.
> 
> > 
> > Note that this is a cosmetic fix at this point as the driver is not yet
> > used for 64-bit systems.
> > 
> > Fixes: feaa8baee82a ("bus: ti-sysc: Implement SoC revision handling")
> > Signed-off-by: Tony Lindgren <tony@...mide.com>
> > ---
> >  drivers/bus/ti-sysc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
> > --- a/drivers/bus/ti-sysc.c
> > +++ b/drivers/bus/ti-sysc.c
> > @@ -3104,7 +3104,7 @@ static int sysc_init_static_data(struct sysc *ddata)
> >  
> >  	match = soc_device_match(sysc_soc_match);
> >  	if (match && match->data)
> > -		sysc_soc->soc = (int)match->data;
> > +		sysc_soc->soc = (unsigned long)match->data;
> 
> Reviewed-by: Dhruva Gole <d-gole@...com>

Dumb q: is'nt this an enum? Is it better to cast it as (enum
sysc_soc)match->data ?

> 
> >  
> >  	/*
> >  	 * Check and warn about possible old incomplete dtb. We now want to see
> > -- 
> > 2.41.0
> 
> -- 
> Best regards,
> Dhruva Gole <d-gole@...com>

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D