linux-kernel - Re: [PATCH v3 1/2] dt-bindings: iio: adc: adding MCP3564 ADC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230805183906.521c90b0@jic23-huawei>
Date:   Sat, 5 Aug 2023 18:39:06 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     <marius.cristea@...rochip.com>
Cc:     <lars@...afoo.de>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
        <linux-iio@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: iio: adc: adding MCP3564 ADC

On Fri, 4 Aug 2023 17:28:19 +0300
<marius.cristea@...rochip.com> wrote:

> From: Marius Cristea <marius.cristea@...rochip.com>
> 
> This is the device tree schema for iio driver for
> Microchip family of 153.6 ksps, Low-Noise 16/24-Bit
> Delta-Sigma ADCs with an SPI interface (Microchip's
> MCP3461, MCP3462, MCP3464, MCP3461R, MCP3462R,
> MCP3464R, MCP3561, MCP3562, MCP3564, MCP3561R,
> MCP3562R and MCP3564R analog to digital converters).
> 
> Signed-off-by: Marius Cristea <marius.cristea@...rochip.com>

Given driver handles the channel label binding, nice to have
that in the example here.


> +
> +examples:
> +  - |
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        adc@0 {
> +            compatible = "microchip,mcp3564r";
> +            reg = <0>;
> +            vref-supply = <&vref_reg>;
> +            spi-cpha;
> +            spi-cpol;
> +            spi-max-frequency = <10000000>;
> +            microchip,hw-device-address = <1>;
> +
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +
> +            channel@0 {
> +                /* CH0 to AGND */
> +                reg = <0>;
> +            };
> +
> +            channel@1 {
> +                /* CH1 to AGND */
> +                reg = <1>;
> +            };
> +
> +            /* diff-channels */
> +            channel@11 {
> +                reg = <11>;
> +
> +                /* CN0, CN1 */
> +                diff-channels = <0 1>;
> +            };
> +
> +            channel@22 {
> +                reg = <0x22>;
> +
> +                /* CN1, CN2 */
> +                diff-channels = <1 2>;
> +            };
> +
> +            channel@23 {
> +                reg = <0x23>;
> +
> +                /* CN1, CN3 */
> +                diff-channels = <1 3>;
> +            };
> +        };
> +    };
> +...