linux-kernel - Re: [PATCH v2 2/2] regulator: dt-bindings: Correct yamllint warnings/errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fa32cc95-6b9d-01e6-b65a-d41f3aeeae4f@linaro.org>
Date:   Sat, 5 Aug 2023 22:00:04 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     like@...nic.com, lgirdwood@...il.com, broonie@...nel.org,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org
Cc:     linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        liweilei@...nic.com, liangdong@...nic.com, wangweidong.a@...nic.com
Subject: Re: [PATCH v2 2/2] regulator: dt-bindings: Correct yamllint
 warnings/errors

On 04/08/2023 12:27, like@...nic.com wrote:
> From: Alec Li <like@...nic.com>
> 

...

Subject: no improvements

> +
> +properties:
> +  compatible:
> +    const: awinic,aw37503
> +
> +  reg:
> +    maxItems: 1
> +
> +patternProperties:
> +  "^out[pn]$":
> +    type: object
> +    $ref: regulator.yaml#

This does not make much sense. You had here unvaluatedProperties. Why
dropping it? I asked to drop additionalProperties. Open the email and
look where the comments are given. In which context.

> +
> +additionalProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +  - outp
> +  - outn
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        regulator@3e {
> +            compatible = "awinic,aw37503";
> +            reg = <0x3e>;
> +
> +            outp {
> +                regulator-name = "outp";
> +                regulator-boot-on;
> +                regulator-always-on;
> +                enable-gpios = <&gpio 17 0>;

Please use proper defines.... you included the header for this.

Best regards,
Krzysztof