linux-kernel - Re: [PATCH -next] i2c: s3c2410: Remove unused extern declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 6 Aug 2023 00:13:39 +0200
From:   Andi Shyti <andi.shyti@...nel.org>
To:     Yue Haibing <yuehaibing@...wei.com>
Cc:     krzysztof.kozlowski@...aro.org, alim.akhtar@...sung.com,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] i2c: s3c2410: Remove unused extern declarations

Hi Yue,

On Fri, Jul 28, 2023 at 09:23:18PM +0800, Yue Haibing wrote:
> commit 0d297df03890 ("ARM: s3c: simplify platform code") left behind
> s3c_i2c(*)_set_platdata().
> commit d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code")
> leave s5p_i2c_hdmiphy_set_platdata() declaration.
> And commit bad1e6aadd17 ("ARM: SAMSUNG: Cleanup plat-samsung/devs.c and devs.h")
> leave s3c_i2c(*)_cfg_gpio() alone.

I don't understand anything from the commit message here.

How about:

"
After some cleanups[*] certain s3c_i2c(*)_cfg_gpio() prototypes
have become unused. Remove them.

[*] 0d297df03890 ("ARM: s3c: simplify platform code")
    d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code")
    bad1e6aadd17 ("ARM: SAMSUNG: Cleanup plat-samsung/devs.c and devs.h")
"

> Signed-off-by: Yue Haibing <yuehaibing@...wei.com>

Reviewed-by: Andi Shyti <andi.shyti@...nel.org> 

which branch should this go? Samsung or i2c?

Andi