linux-kernel - RE: [PATCH] i2c: tegra: Fix the check during DMA channel release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DS7PR12MB633567393B1A709323983DADC00FA@DS7PR12MB6335.namprd12.prod.outlook.com>
Date:   Sun, 6 Aug 2023 14:26:33 +0000
From:   Akhil R <akhilrajeev@...dia.com>
To:     Andi Shyti <andi.shyti@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>
CC:     "christian.koenig@....com" <christian.koenig@....com>,
        "digetx@...il.com" <digetx@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Laxman Dewangan <ldewangan@...dia.com>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        "sumit.semwal@...aro.org" <sumit.semwal@...aro.org>,
        "wsa@...nel.org" <wsa@...nel.org>
Subject: RE: [PATCH] i2c: tegra: Fix the check during DMA channel release

> Hi Thierry and Akhil,
> 
> On Mon, Jul 17, 2023 at 05:24:15PM +0200, Thierry Reding wrote:
> > On Mon, Jul 17, 2023 at 08:42:40PM +0530, Akhil R wrote:
> > > Check for error and NULL before attempting to release DMA channel.
> > >
> > > This, otherwise, was causing panic and crash in kernel when the
> > > dma_chan has an invalid value. The condition occurs during
> > > init_dma() when the dma_request_chan() function returns an error.
> > >
> > > Fixes: fcc8a89a1c83 ("i2c: tegra: Share same DMA channel for RX and
> > > TX")
> > > Signed-off-by: Akhil R <akhilrajeev@...dia.com>
> > > ---
> > >  drivers/i2c/busses/i2c-tegra.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> I guess this patch is not needed anymore.
Correct. This can be discarded.

The below patch from Thierry is for the same fix. 
https://lore.kernel.org/linux-i2c/20230707132619.2998382-1-thierry.reding@gmail.com/

Regards,
Akhil