linux-kernel - Re: [PATCH 3/3] arm64: dts: ti: k3-am64: Fix epwm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 6 Aug 2023 10:33:59 +0200
From:   Francesco Dolcini <francesco@...cini.it>
To:     Andrew Davis <afd@...com>, Nishanth Menon <nm@...com>
Cc:     Vignesh Raghavendra <vigneshr@...com>,
        Tero Kristo <kristo@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: ti: k3-am64: Fix epwm_tbclk node name to
 generic name

Hello Andrew, hello Nishanth

On Wed, Aug 02, 2023 at 12:45:21PM -0500, Andrew Davis wrote:
> The name "clock" is not allowed for nodes, use "clock-controller" to
> remove the DTS check warning.
> 
> Signed-off-by: Andrew Davis <afd@...com>
> ---
>  arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> index e27eb2e585f14..4e3e450e4e4c8 100644
> --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> @@ -61,7 +61,7 @@ phy_gmii_sel: phy@...4 {
>  			#phy-cells = <1>;
>  		};
>  
> -		epwm_tbclk: clock@...0 {
> +		epwm_tbclk: clock-controller@...0 {

I was asked to do the exact same change here [1] by Nishanth, and I'm
sending the updated patch in a short while.

However I have one question, according to the
devicetree-specification-v0.4.pdf [2] "2.2.2 Generic Names
Recommendation", clock is a valid node name.

While testing the DT (make CHECK_DTBS=y), I did not have any warning nor
error.

What am I missing?

In addition to that I guess we should also update the example in the dt
bindings yaml file.

Francesco


[1] https://lore.kernel.org/all/20230731142135.108477-2-francesco@dolcini.it/
[2] https://github.com/devicetree-org/devicetree-specification/releases/download/v0.4/devicetree-specification-v0.4.pdf