[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <401de8fb-8d33-d699-ba09-a7b90356d915@linux.intel.com>
Date: Mon, 7 Aug 2023 09:28:35 -0500
From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
alsa-devel@...a-project.org
Cc: Maarten Lankhorst <dev@...khorst.se>,
Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>,
Cezary Rojewski <cezary.rojewski@...el.com>,
Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
Bard Liao <yung-chuan.liao@...ux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
Mark Brown <broonie@...nel.org>,
Daniel Baluta <daniel.baluta@....com>,
linux-kernel@...r.kernel.org, sound-open-firmware@...a-project.org
Subject: Re: [PATCH v3 9/9] ALSA: hda/i915: Remove extra argument from
snd_hdac_i915_init
> @@ -172,18 +172,10 @@ int snd_hdac_i915_init(struct hdac_bus *bus, bool allow_modprobe)
> acomp = bus->audio_component;
> if (!acomp)
> return -ENODEV;
> - if (allow_modprobe && !acomp->ops) {
> - if (!IS_ENABLED(CONFIG_MODULES) ||
> - !request_module("i915")) {
> - /* 60s timeout */
> - wait_for_completion_killable_timeout(&acomp->master_bind_complete,
> - msecs_to_jiffies(60 * 1000));
heads-up that I have a conflicting patch to make the 60s delay
configurable, see https://github.com/thesofproject/linux/pull/4505
> - }
> - }
> if (!acomp->ops) {
> - int err = allow_modprobe ? -ENODEV : -EPROBE_DEFER;
> snd_hdac_acomp_exit(bus);
> - return dev_err_probe(bus->dev, err, "couldn't bind with audio component\n");
> + return dev_err_probe(bus->dev, -EPROBE_DEFER,
> + "couldn't bind with audio component\n");
> }
> return 0;
> }
Powered by blists - more mailing lists