[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZNEJA1E6ouOuaAcc@vergenet.net>
Date: Mon, 7 Aug 2023 17:08:51 +0200
From: Simon Horman <horms@...nel.org>
To: Guangguan Wang <guangguan.wang@...ux.alibaba.com>
Cc: wenjia@...ux.ibm.com, jaka@...ux.ibm.com, kgraul@...ux.ibm.com,
tonylu@...ux.alibaba.com, davem@...emloft.net, edumazet@...gle.com,
kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
alibuda@...ux.alibaba.com, guwen@...ux.alibaba.com,
linux-s390@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH v2 net-next 5/6] net/smc: support max links per lgr
negotiation in clc handshake
On Mon, Aug 07, 2023 at 02:27:19PM +0800, Guangguan Wang wrote:
...
> diff --git a/net/smc/smc_llc.c b/net/smc/smc_llc.c
...
> @@ -1414,6 +1420,9 @@ int smc_llc_srv_add_link(struct smc_link *link,
> goto out;
> }
>
> + if (lgr->type == SMC_LGR_SINGLE && lgr->max_links <= 1)
Hi Guangguan Wang,
The function will return rc.
Should it be set to an error value here?
Flagged by Smatch.
> + goto out;
> +
> /* ignore client add link recommendation, start new flow */
> ini->vlan_id = lgr->vlan_id;
> if (lgr->smc_version == SMC_V2) {
> --
> 2.24.3 (Apple Git-128)
>
Powered by blists - more mailing lists