linux-kernel - Re: [PATCH] serial: max310x: add comments for membase address workaround

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230807112441.c8aa3891cfd6da6b8c65cafc@hugovil.com>
Date:   Mon, 7 Aug 2023 11:24:41 -0400
From:   Hugo Villeneuve <hugo@...ovil.com>
To:     Hugo Villeneuve <hugo@...ovil.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        linux-serial@...r.kernel.org,
        Hugo Villeneuve <hvilleneuve@...onoff.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] serial: max310x: add comments for membase address
 workaround

On Fri, 4 Aug 2023 10:17:22 -0400
Hugo Villeneuve <hugo@...ovil.com> wrote:

> On Fri, 4 Aug 2023 15:07:50 +0200
> Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:
> 
> > On Thu, Aug 03, 2023 at 10:05:51AM -0400, Hugo Villeneuve wrote:
> > > From: Hugo Villeneuve <hvilleneuve@...onoff.com>
> > > 
> > > Add comments about workaround used to configure membase address. This
> > > follows suggestions made during review of a sc16is7xx driver patch to
> > > add the same workaround.
> > > 
> > > Link: https://lore.kernel.org/lkml/2936e18f-44ea-faed-9fa0-2ddefe7c3194@linux.intel.com
> > > Link: https://lore.kernel.org/lkml/20230801131655.80bd8f97f018dda6155d65f6@hugovil.com/
> > > Signed-off-by: Hugo Villeneuve <hvilleneuve@...onoff.com>
> > > ---
> > >  drivers/tty/serial/max310x.c | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > > 
> > > diff --git a/drivers/tty/serial/max310x.c b/drivers/tty/serial/max310x.c
> > > index 416d553b73a7..5903dd033fd0 100644
> > > --- a/drivers/tty/serial/max310x.c
> > > +++ b/drivers/tty/serial/max310x.c
> > > @@ -1369,6 +1369,11 @@ static int max310x_probe(struct device *dev, const struct max310x_devtype *devty
> > >  		s->p[i].port.flags	= UPF_FIXED_TYPE | UPF_LOW_LATENCY;
> > >  		s->p[i].port.iotype	= UPIO_PORT;
> > >  		s->p[i].port.iobase	= i;
> > > +		/*
> > > +		 * Use all ones as membase to make sure uart_configure_port() in
> > > +		 * serial_core.c does not abort for SPI/I2C devices where the
> > > +		 * membase address is not applicable.
> > > +		 */
> > >  		s->p[i].port.membase	= (void __iomem *)~0;
> > >  		s->p[i].port.uartclk	= uartclk;
> > >  		s->p[i].port.rs485_config = max310x_rs485_config;
> > > 
> > > base-commit: 426263d5fb400ccde5444748693dc75bda18f01e
> > > -- 
> > > 2.30.2
> > > 
> > 
> > Meta-comment, your email system is not correct and is not able to be
> > verified as I get the following when attempting to apply your patch:
> > 
> > ---
> >   ✗ [PATCH] serial: max310x: add comments for membase address workaround
> >   ---
> >   ✗ BADSIG: DKIM/hugovil.com
> > 
> > Please fix up for future submissions.
> > 
> > thanks,
> > 
> > greg k-h
> 
> Hi Greg,
> I will look into it. Thank you.

Hi Greg,
I double-checked my DKIM setup, but everything looks fine. If I send
emails to gmail or outlook servers, they both report "DKIM
signature=pass", and I also checked with an online DKIM validation
service and it is also ok.

What tool are you using to check the DKIM signature?

Thank you,
Hugo.