[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZNENYFMHPFgQkXQK@smile.fi.intel.com>
Date: Mon, 7 Aug 2023 18:27:28 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Petr Mladek <pmladek@...e.com>
Cc: Marco Elver <elver@...gle.com>, linux-kernel@...r.kernel.org,
kasan-dev@...glegroups.com, linux-mm@...ck.org,
Steven Rostedt <rostedt@...dmis.org>,
Rasmus Villemoes <linux@...musvillemoes.dk>,
Sergey Senozhatsky <senozhatsky@...omium.org>,
Alexander Potapenko <glider@...gle.com>,
Dmitry Vyukov <dvyukov@...gle.com>,
Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v2 3/3] lib/vsprintf: Declare no_hash_pointers in
sprintf.h
On Mon, Aug 07, 2023 at 05:06:33PM +0200, Petr Mladek wrote:
> On Sat 2023-08-05 20:50:27, Andy Shevchenko wrote:
> > Sparse is not happy to see non-static variable without declaration:
> > lib/vsprintf.c:61:6: warning: symbol 'no_hash_pointers' was not declared. Should it be static?
> >
> > Declare respective variable in the sprintf.h. With this, add a comment
> > to discourage its use if no real need.
> If we agreed to move sprintf() declarations into printk.h
> then this might go to printk.h as well.
Sure, but I disagree with printk.h approach (as I explained why in the reply
to the suggestion).
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists