linux-kernel - Re: [PATCH v2] arm64: dts: ti: k3-j784s4-evm: Correct Pin mux offset for ospi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 7 Aug 2023 10:54:59 -0500
From:   Nishanth Menon <nm@...com>
To:     "Kumar, Udit" <u-kumar1@...com>
CC:     Vaishnav Achath <vaishnav.a@...com>, <vigneshr@...com>,
        <kristo@...nel.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
        <t-konduru@...com>, <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Bhavya Kapoor <b-kapoor@...com>
Subject: Re: [PATCH v2] arm64: dts: ti: k3-j784s4-evm: Correct Pin mux offset
 for ospi

On 20:33-20230807, Kumar, Udit wrote:
> Thanks Vaishnav.
> 
> Hi Nishanth,
> 
> On 8/7/2023 8:09 PM, Vaishnav Achath wrote:
> > Hi Udit,
> > 
> > On 02/08/23 17:11, Udit Kumar wrote:
> > > [...]
> > > Thank you for the patch,
> > > 
> > > For OSPI functionality:
> > > 
> > > Tested-by: Vaishnav Achath <vaishnav.a@...com>
> > > 
> > > before: https://gist.github.com/vaishnavachath/c87275e53f6ae38bacc44c65ed09c733
> > > (QSPI probe fails due to wrong pinmux)
> > > after: https://gist.github.com/vaishnavachath/b5f6147cfae5218815aca94ec0dfd991
> > > (both QSPI, OSPI is functional)
> > > 
> > > heads-up :
> > > I see the following warnings for ADC:
> > > 
> > > ```
> > >   pinctrl-single 4301c068.pinctrl: mux offset out of range: 0x134 (0x120)
> > >   pinctrl-single 4301c068.pinctrl: could not add functions for
> > > mcu-adc0-default-pins 308x
> > > pinctrl-single 4301c068.pinctrl: mux offset out of range: 0x154 (0x120)
> > > pinctrl-single 4301c068.pinctrl: could not add functions for
> > > mcu-adc1-default-pins 340x
> > > ```
> > > 
> > > mcu_adc0_pins_default and mcu_adc1_pins_default entries needs to have the
> > > wkup_pmx2 base (0x68) subtracted to get the appropriate offsets, not sure if
> > > there is already a patch addressing the same or should be part of this patch.
> 
> let me know, if you are ok with other patch to address adc pin mux or I
> should respin with adc changes

adc fixes come separate on top - for the next time please:

Roll these fixes out in a single series.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D