linux-kernel - Re: [PATCH] drm/amd/display: Return value of function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_MSXxaAnF+4t1X_v0enooY5Xb8BSpo8f7pPe8g7mPT6AQ@mail.gmail.com>
Date:   Mon, 7 Aug 2023 12:06:49 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Denis Arefev <arefev@...mel.ru>
Cc:     Harry Wentland <harry.wentland@....com>, trufanov@...mel.ru,
        lvc-project@...uxtesting.org, Leo Li <sunpeng.li@....com>,
        Wenjing Liu <wenjing.liu@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
        linux-kernel@...r.kernel.org, amd-gfx@...ts.freedesktop.org,
        vfh@...mel.ru, dri-devel@...ts.freedesktop.org,
        Alex Deucher <alexander.deucher@....com>,
        Jun Lei <Jun.Lei@....com>,
        Christian König <christian.koenig@....com>
Subject: Re: [PATCH] drm/amd/display: Return value of function

Applied.  Thanks!

On Thu, Aug 3, 2023 at 10:18 AM Denis Arefev <arefev@...mel.ru> wrote:
>
> Added return value check hpd_enable
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Denis Arefev <arefev@...mel.ru>
> ---
>  drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c b/drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c
> index fa314493ffc5..bf2f620aeb66 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c
> @@ -1645,7 +1645,7 @@ void dce110_link_encoder_enable_hpd(struct link_encoder *enc)
>         uint32_t hpd_enable = 0;
>         uint32_t value = dm_read_reg(ctx, addr);
>
> -       get_reg_field_value(hpd_enable, DC_HPD_CONTROL, DC_HPD_EN);
> +       hpd_enable = get_reg_field_value(hpd_enable, DC_HPD_CONTROL, DC_HPD_EN);
>
>         if (hpd_enable == 0)
>                 set_reg_field_value(value, 1, DC_HPD_CONTROL, DC_HPD_EN);
> --
> 2.25.1
>