linux-kernel - Re: [PATCH] drm/amd/pm: Clean up errors in smu_v13_0_7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_OzhDL6tfu2HH2SDEQOnPukvoM0fPm3NN9ORSqOxrq1Wg@mail.gmail.com>
Date:   Mon, 7 Aug 2023 12:19:14 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Ran Sun <sunran001@...suo.com>
Cc:     apw@...onical.com, joe@...ches.com, alexander.deucher@....com,
        bpf@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        amd-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amd/pm: Clean up errors in smu_v13_0_7_ppt.c

Applied.  Thanks!

On Mon, Jul 31, 2023 at 9:26 PM Ran Sun <sunran001@...suo.com> wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: open brace '{' following struct go on the same line
> ERROR: spaces required around that '=' (ctx:VxW)
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Ran Sun <sunran001@...suo.com>
> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
> index b1f0937ccade..26ba51ec0567 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
> @@ -386,8 +386,7 @@ static int smu_v13_0_7_check_fw_status(struct smu_context *smu)
>  }
>
>  #ifndef atom_smc_dpm_info_table_13_0_7
> -struct atom_smc_dpm_info_table_13_0_7
> -{
> +struct atom_smc_dpm_info_table_13_0_7 {
>         struct atom_common_table_header table_header;
>         BoardTable_t BoardTable;
>  };
> @@ -494,7 +493,7 @@ static int smu_v13_0_7_tables_init(struct smu_context *smu)
>                        PAGE_SIZE, AMDGPU_GEM_DOMAIN_VRAM);
>         SMU_TABLE_INIT(tables, SMU_TABLE_ACTIVITY_MONITOR_COEFF,
>                        sizeof(DpmActivityMonitorCoeffIntExternal_t), PAGE_SIZE,
> -                      AMDGPU_GEM_DOMAIN_VRAM);
> +                      AMDGPU_GEM_DOMAIN_VRAM);
>         SMU_TABLE_INIT(tables, SMU_TABLE_COMBO_PPTABLE, MP0_MP1_DATA_REGION_SIZE_COMBOPPTABLE,
>                         PAGE_SIZE, AMDGPU_GEM_DOMAIN_VRAM);
>
> @@ -728,7 +727,7 @@ static int smu_v13_0_7_get_smu_metrics_data(struct smu_context *smu,
>                                             MetricsMember_t member,
>                                             uint32_t *value)
>  {
> -       struct smu_table_context *smu_table= &smu->smu_table;
> +       struct smu_table_context *smu_table = &smu->smu_table;
>         SmuMetrics_t *metrics =
>                 &(((SmuMetricsExternal_t *)(smu_table->metrics_table))->SmuMetrics);
>         int ret = 0;
> @@ -1635,8 +1634,7 @@ static int smu_v13_0_7_force_clk_levels(struct smu_context *smu,
>         return ret;
>  }
>
> -static const struct smu_temperature_range smu13_thermal_policy[] =
> -{
> +static const struct smu_temperature_range smu13_thermal_policy[] = {
>         {-273150,  99000, 99000, -273150, 99000, 99000, -273150, 99000, 99000},
>         { 120000, 120000, 120000, 120000, 120000, 120000, 120000, 120000, 120000},
>  };
> --
> 2.17.1
>