linux-kernel - Re: [PATCH] drm/amd/pm: Clean up errors in smu_v13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 7 Aug 2023 12:20:12 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Ran Sun <sunran001@...suo.com>
Cc:     alexander.deucher@....com, airlied@...il.com, daniel@...ll.ch,
        dri-devel@...ts.freedesktop.org, amd-gfx@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amd/pm: Clean up errors in smu_v13_0.c

Applied.  Thanks!

On Mon, Jul 31, 2023 at 9:43 PM Ran Sun <sunran001@...suo.com> wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: space required before the open parenthesis '('
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Ran Sun <sunran001@...suo.com>
> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
> index 9b62b45ebb7f..895cda8e6934 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
> @@ -1121,7 +1121,7 @@ smu_v13_0_display_clock_voltage_request(struct smu_context *smu,
>
>                 ret = smu_v13_0_set_hard_freq_limited_range(smu, clk_select, clk_freq, 0);
>
> -               if(clk_select == SMU_UCLK)
> +               if (clk_select == SMU_UCLK)
>                         smu->hard_min_uclk_req_from_dal = clk_freq;
>         }
>
> @@ -1437,8 +1437,7 @@ static int smu_v13_0_irq_process(struct amdgpu_device *adev,
>         return 0;
>  }
>
> -static const struct amdgpu_irq_src_funcs smu_v13_0_irq_funcs =
> -{
> +static const struct amdgpu_irq_src_funcs smu_v13_0_irq_funcs = {
>         .set = smu_v13_0_set_irq_state,
>         .process = smu_v13_0_irq_process,
>  };
> @@ -1933,7 +1932,7 @@ static int smu_v13_0_get_dpm_level_count(struct smu_context *smu,
>
>         ret = smu_v13_0_get_dpm_freq_by_index(smu, clk_type, 0xff, value);
>         /* SMU v13.0.2 FW returns 0 based max level, increment by one for it */
> -       if((smu->adev->ip_versions[MP1_HWIP][0] == IP_VERSION(13, 0, 2)) && (!ret && value))
> +       if ((smu->adev->ip_versions[MP1_HWIP][0] == IP_VERSION(13, 0, 2)) && (!ret && value))
>                 ++(*value);
>
>         return ret;
> --
> 2.17.1
>