linux-kernel - Re: [PATCH] drm/amd/pm: Clean up errors in vega20

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_MbmP9sEkWHndxaG+pp6bJkeO7h1qvya3wZWmktDpFYpQ@mail.gmail.com>
Date:   Mon, 7 Aug 2023 12:49:45 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Ran Sun <sunran001@...suo.com>
Cc:     alexander.deucher@....com, airlied@...il.com, daniel@...ll.ch,
        dri-devel@...ts.freedesktop.org, amd-gfx@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amd/pm: Clean up errors in vega20_pptable.h

Applied.  Thanks!

On Tue, Aug 1, 2023 at 5:44 AM Ran Sun <sunran001@...suo.com> wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: open brace '{' following struct go on the same line
> ERROR: space prohibited before open square bracket '['
>
> Signed-off-by: Ran Sun <sunran001@...suo.com>
> ---
>  .../amd/pm/powerplay/hwmgr/vega20_pptable.h   | 19 ++++++++-----------
>  1 file changed, 8 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_pptable.h b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_pptable.h
> index 2222e29405c6..b468dddbefff 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_pptable.h
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_pptable.h
> @@ -73,14 +73,13 @@ enum ATOM_VEGA20_ODSETTING_ID {
>  };
>  typedef enum ATOM_VEGA20_ODSETTING_ID ATOM_VEGA20_ODSETTING_ID;
>
> -typedef struct _ATOM_VEGA20_OVERDRIVE8_RECORD
> -{
> +typedef struct _ATOM_VEGA20_OVERDRIVE8_RECORD {
>    UCHAR ucODTableRevision;
>    ULONG ODFeatureCount;
> -  UCHAR ODFeatureCapabilities [ATOM_VEGA20_ODFEATURE_MAX_COUNT];   //OD feature support flags
> +  UCHAR ODFeatureCapabilities[ATOM_VEGA20_ODFEATURE_MAX_COUNT];   //OD feature support flags
>    ULONG ODSettingCount;
> -  ULONG ODSettingsMax [ATOM_VEGA20_ODSETTING_MAX_COUNT];           //Upper Limit for each OD Setting
> -  ULONG ODSettingsMin [ATOM_VEGA20_ODSETTING_MAX_COUNT];           //Lower Limit for each OD Setting
> +  ULONG ODSettingsMax[ATOM_VEGA20_ODSETTING_MAX_COUNT];           //Upper Limit for each OD Setting
> +  ULONG ODSettingsMin[ATOM_VEGA20_ODSETTING_MAX_COUNT];           //Lower Limit for each OD Setting
>  } ATOM_VEGA20_OVERDRIVE8_RECORD;
>
>  enum ATOM_VEGA20_PPCLOCK_ID {
> @@ -99,16 +98,14 @@ enum ATOM_VEGA20_PPCLOCK_ID {
>  };
>  typedef enum ATOM_VEGA20_PPCLOCK_ID ATOM_VEGA20_PPCLOCK_ID;
>
> -typedef struct _ATOM_VEGA20_POWER_SAVING_CLOCK_RECORD
> -{
> +typedef struct _ATOM_VEGA20_POWER_SAVING_CLOCK_RECORD {
>    UCHAR ucTableRevision;
>    ULONG PowerSavingClockCount;                                 // Count of PowerSavingClock Mode
> -  ULONG PowerSavingClockMax  [ATOM_VEGA20_PPCLOCK_MAX_COUNT];      // PowerSavingClock Mode Clock Maximum array In MHz
> -  ULONG PowerSavingClockMin  [ATOM_VEGA20_PPCLOCK_MAX_COUNT];      // PowerSavingClock Mode Clock Minimum array In MHz
> +  ULONG PowerSavingClockMax[ATOM_VEGA20_PPCLOCK_MAX_COUNT];      // PowerSavingClock Mode Clock Maximum array In MHz
> +  ULONG PowerSavingClockMin[ATOM_VEGA20_PPCLOCK_MAX_COUNT];      // PowerSavingClock Mode Clock Minimum array In MHz
>  } ATOM_VEGA20_POWER_SAVING_CLOCK_RECORD;
>
> -typedef struct _ATOM_VEGA20_POWERPLAYTABLE
> -{
> +typedef struct _ATOM_VEGA20_POWERPLAYTABLE {
>        struct atom_common_table_header sHeader;
>        UCHAR  ucTableRevision;
>        USHORT usTableSize;
> --
> 2.17.1
>